$args = $args[0] ; #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json_encode
nizsheanez
requested changes
Apr 24, 2019
| @@ -17,6 +17,9 @@ public function getParams($method) | |||
| { | |||
| $params = []; | |||
| $args = isset($this->_data['params']) ? $this->_data['params'] : []; | |||
|
|
|||
| if(isset($args[0]) && is_array($args[0])) $args = $args[0]; | |||
There was a problem hiding this comment.
Thank you.
This line doesn't follow JSON RPS 2.0 specification:
https://www.jsonrpc.org/specification#request_object
by-position: params MUST be an Array, containing the values in the Server expected order.
not first element inside params must be Array, but params itself must be an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$args = $args[0] ; json_encode